Show overall "All checks have passed" status in github even on builds with incomplete "type: approval" job

I added a manual approval "trigger_rollback" job recently to my Circle 2.0 workflow and did not like the UI integration with github. On builds where I did not trigger this optional "trigger_rollback" job, the overall Github status was "Some checks haven't completed yet." (See screenshot.)

 

I talked to CircleCI support and they told me to deselect the status check for a "type: approval" job as described in this github article: https://circleci.com/docs/2.0/workflows-waiting-status/, which I had already done.

 

I still need the "trigger_rollback" job and corresponding status check. The "trigger_rollback" status check is type:approval, so I want it to be pending but I don't want the overall PR status to be pending -- instead I want the overall PR status to be green and say "All checks have passed."

  • Lydia Stepanek
  • Jun 4 2018
  • Taking votes
  • Attach files
  • Patrick Hübl-Neschkudla commented
    29 Jul 17:49

    I'm surprised that there is still no word on this feature. The missing option to mark manual approval steps as optional makes our circleci workflows basically incompatible with many 3rd party services (codecov is also not commenting on prs until the workflow is marked as completed).

  • Mykhailo Chalyi commented
    08 Jun 14:05

    +1, renders impossible optional jobs :(

  • Tyler Sheaffer commented
    26 Mar 16:26

    Is there any capability around this? This is really valuable for us as well, otherwise all of our successful builds look yellow instead of green.

  • jacopo beschi commented
    14 Jan 17:03

    +1 Having the same issue in our workflow

  • Matthieu D commented
    December 30, 2019 19:02

    Any chance to have an update on this?

     

    This seems like an easy fix, proposals in merged ideas make sense.

    In my mind, something like this would be ideal:

     

    report: {true,false,always-success}

     

    The lack of such a feature makes it super painful to use approval jobs today w/ GitHub - using them implies losing useful UX there.

  • James Pike commented
    October 16, 2019 16:24

    Not having this feature means we cannot consider CircleCI.

  • Arthur Lysenko commented
    May 21, 2019 11:26

    +1. We need this feature in our Github integration.

  • Fernando Aguero commented
    November 27, 2018 12:55

    Same issue here. We have an optinal approval step in case we want to manually deploy a branch to an environment. That doesn't mean that the tests are not passing. It's pretty annoying.

  • Joe Rieger commented
    October 17, 2018 19:43

    I'd love to have this feature. We want the approval as part of our work-in-process pipeline, without making every status check on the Pull Requests page in git show everything as pending.